−2) · working-list #572 #21

Merged

Connor merged 1 commit from build/1a8f6c96 into main

2026-09-30 12:31:25 +00:00

Connor commented

2026-09-30 12:30:10 +00:00

Owner

What changed

build/1a8f6c96 → main — 1 file(s), +2/−2.

source: 1 file(s), +2/−2
src/lib/knap.ts

Why

I've given the error-list parameter e in src/lib/knap.ts an explicit type, and the clean install, the build and the repo gate all passed. But this change alone won't fix the publish. The TS7006 error was a side effect of a missing package, not a missing annotation. Publish will only go green once the publish machine gets a fresh install that includes knap.

What was actually breaking the publish

With knap installed, TypeScript already works out that e is a Knap TemplateError. The strict build found no other implicit-any in the file. I reproduced your exact error by moving node_modules/knap aside, and tsc then reported three errors:

"Cannot find module 'knap'" on both import lines.
The (75,40) implicit-any, because a missing module makes everything built from it untyped.

Your publish log showed only the third error. That matches what step 1 of this plan found: the publish clone was building against an old September node_modules with no knap in it. That's defect #117, where a dependency folder with no install record was reused instead of reinstalled. Step 2 fixed it in Connor as PR #667. The publish goes green once #667 is merged and deployed and publish is rerun on main. I didn't check whether #667 has landed, so please confirm that before rerunning.

The one change […]

Gate

npm run gate ran 243 tests in 2.4s and exited 0 — green.

Flow engine

⚠ Not reviewed by the flow engine. The engine errored, so this change took the direct path: no flow engine command is set (flow.route_command)

Built by Connor's frontend backburner (dispatch 1a8f6c96) in an isolated clone; shipped deterministically by ship.py. The full build notes were spoken in conversation and stored in memory (agent-dispatch:1a8f6c96). Review is the gate.

The brief this build was given

Kept for provenance. This is the task the builder was dispatched with — not a description of the diff above.

Requested: Fix the plugin build break that has failed every publish since 2026-09-29: npm run build exits 2 on src/lib/knap.ts(75,40): error TS7006: Parameter 'e' implicitly has an 'any' type. Give that parameter (and any other implicit-any the strict build reports in src/lib/knap.ts) an explicit correct type, without loosening tsconfig strictness. Run a clean npm ci && npm run build and the repo gate to prove the build is green. Working-list item #572.

### What changed `build/1a8f6c96` → `main` — 1 file(s), +2/−2. - **source**: 1 file(s), +2/−2 - `src/lib/knap.ts` ### Why I've given the error-list parameter `e` in `src/lib/knap.ts` an explicit type, and the clean install, the build and the repo gate all passed. But **this change alone won't fix the publish.** The TS7006 error was a side effect of a missing package, not a missing annotation. Publish will only go green once the publish machine gets a fresh install that includes `knap`. ## What was actually breaking the publish With `knap` installed, TypeScript already works out that `e` is a Knap `TemplateError`. The strict build found no other implicit-any in the file. I reproduced your exact error by moving `node_modules/knap` aside, and `tsc` then reported three errors: - "Cannot find module 'knap'" on both import lines. - The `(75,40)` implicit-any, because a missing module makes everything built from it untyped. Your publish log showed only the third error. That matches what step 1 of this plan found: the publish clone was building against an old September `node_modules` with no `knap` in it. That's defect #117, where a dependency folder with no install record was reused instead of reinstalled. Step 2 fixed it in Connor as PR #667. The publish goes green once #667 is merged and deployed and publish is rerun on main. I didn't check whether #667 has landed, so please confirm that before rerunning. ## The one change […] ### Gate `npm run gate` ran 243 tests in 2.4s and exited 0 — green. ### Flow engine > ⚠ **Not reviewed by the flow engine.** The engine errored, so this change took the direct path: no flow engine command is set (flow.route_command) Built by Connor's frontend backburner (dispatch `1a8f6c96`) in an isolated clone; shipped deterministically by `ship.py`. The full build notes were spoken in conversation and stored in memory (`agent-dispatch:1a8f6c96`). Review is the gate. --- ### The brief this build was given _Kept for provenance. This is the task the builder was dispatched with — not a description of the diff above._ > Requested: Fix the plugin build break that has failed every publish since 2026-09-29: `npm run build` exits 2 on src/lib/knap.ts(75,40): error TS7006: Parameter 'e' implicitly has an 'any' type. Give that parameter (and any other implicit-any the strict build reports in src/lib/knap.ts) an explicit correct type, without loosening tsconfig strictness. Run a clean `npm ci && npm run build` and the repo gate to prove the build is green. Working-list item #572.

Joel was assigned by Connor

2026-09-30 12:30:10 +00:00

Connor added 1 commit

2026-09-30 12:30:10 +00:00

build: Fix the plugin build break that has failed every publish since…

gate / gate (pull_request) Successful in 8s

Details

3326e80b2e

Fix the plugin build break that has failed every publish since 2026-09-29: `npm run build` exits 2 on src/lib/knap.ts(75,40): error TS7006: Parameter 'e' implicitly has an 'any' type. Give that parameter (and any other implicit-any the strict build reports in src/lib/knap.ts) an explicit correct type, without loosening tsconfig strictness. Run a clean `npm ci && npm run build` and the repo gate to prove the build is green. Working-list item #572.

Built by my frontend backburner (dispatch 1a8f6c96), diff verified by git; shipped by ship.py. Nothing merges without review.

Connor requested review from reviewer-bot

2026-09-30 12:30:10 +00:00

reviewer-bot approved these changes

2026-09-30 12:30:55 +00:00

reviewer-bot left a comment

Independent review — reviewer-bot (local model qwen2.5-coder:14b)

The PR correctly imports an additional type and properly types the error handling. It matches its stated intent without introducing new issues.

**Independent review — reviewer-bot (local model `qwen2.5-coder:14b`)** The PR correctly imports an additional type and properly types the error handling. It matches its stated intent without introducing new issues.

Connor merged commit b493dc9b19 into main

2026-09-30 12:31:25 +00:00

Connor deleted branch build/1a8f6c96

2026-09-30 12:31:25 +00:00

Connor referenced this pull request from a commit

2026-09-30 12:31:26 +00:00

Merge pull request 'code: src/lib/knap.ts (+2/−2) · working-list #572' (#21) from build/1a8f6c96 into main